Dan Kenigsberg has posted comments on this change.
Change subject: Add getOSName() method in deployUtil for OS detection
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
when you say "verify", it is better to give a hint about the nature of the
verification. I believe that the posted code would cause several troubles, eg
not filling /etc/pki/vdsm.
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 73: deployUtil.versionCompare(deployUtil.getOSVersion(), "6.0"))
>= 0:
Line 74: rhel6based = True
Line 75:
Line 76: if (deployUtil.getOSName().lower() == "fedora" and
Line 77: deployUtil.versionCompare(deployUtil.getOSVersion(), "16")) >=
0:
unfortunately, the rest of the code assumes that you set
rhel6based = True
too. very ugly. must be changed. and commented and maintained until it is
changed.
Line 78: fedorabased = True
Line 79:
Line 80: logging.debug("fedorabased=%d rhel6based=%d", fedorabased, rhel6based)
Line 81:
....................................................
File vdsm_reg/deployUtil.py.in
Line 459: """
Line 460:
Line 461: # platform.linux_distribution returns a tuple (distname, version,
id) or
Line 462: # default as given in args in case of any failure
Line 463: osName = platform.linux_distribution(distname='Unknown OS',
version='')
I do not think we need this 'Unknown OS' ugliness - we have no silly behavior
to maintain.
Line 464: logging.debug("OS Name = %s", osName[0])
Line 465: return osName[0]
Line 466:
Line 467: def getKernelVR():
--
To view, visit http://gerrit.ovirt.org/8002
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifff9b08902cd234dfa03292136317d50e5e3d22b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
