Dan Kenigsberg has posted comments on this change.
Change subject: add and use hypervisor autodetection in bootstrap.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 19: Modified the vds_bootstrap to use the autodetection code.
Line 20: The setting based on the `fake_kvm_support' is left as last
Line 21: fallback.
Line 22:
Line 23: Address all the comments made in the reviews.
Could you explain here why we want to allow installation within guests, even if
the guest does not have nested virt?
even if we do want to succeed in installing on such hosts (for testing etc), we
should better report a WARNING to Engine, or else nasty surprises may occur
when it tries to start a VM on the host.
Line 24:
Line 25: Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
....................................................
File vdsm_reg/deployUtil.py.in
Line 1354: elif hid == 'XenVMMXenVMM':
Line 1355: name = 'xen'
Line 1356: elif hid == 'KVMKVMKVM':
Line 1357: name = 'kvm'
Line 1358: elif 'QEMU' in cpuModelName():
qemu does not set the cpuHypervisorID? Isn't it a qemu bug? (I really do not
know)
Line 1359: name = 'qemu'
Line 1360: logging.debug('detected hypervisor: %s', name)
Line 1361: return name
Line 1362:
--
To view, visit http://gerrit.ovirt.org/7657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
