Zhou Zheng Sheng has posted comments on this change.

Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
......................................................................


Patch Set 1:

Good idea Dan. If someone add a .py.in to git but forget to add the .py file to 
.gitignore, he can not successfully make. 

How about putting this verification to autobuild.sh instead of Makefile, with 
some friendly error message?

--
To view, visit http://gerrit.ovirt.org/7890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f35bd0c4416c5319ef51d1a751b367a3e37d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to