Zhou Zheng Sheng has posted comments on this change. Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore ......................................................................
Patch Set 2: (1 inline comment) .................................................... File Makefile.am Line 121: Line 122: [ -f .gitignore ] || exit 0; \ Line 123: gitignore=`mktemp`; \ Line 124: lsfiles=`mktemp`; \ Line 125: LC_ALL=C sort .gitignore > "$$gitignore"; \ Emmm.... I tried to run the command directly, it seems a single "$" is enough. $$ is expanded to the current pid, so $$gitignore will be expanded to a string like "3950gitigore". Line 126: git ls-files '*.py.in' | sed 's/\.in$$//' | \ Line 127: LC_ALL=C sort > "$$lsfiles"; \ Line 128: LC_ALL=C comm -1 -3 "$$gitignore" "$$lsfiles" | \ Line 129: grep . && exit 1 || exit 0 -- To view, visit http://gerrit.ovirt.org/7890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f35bd0c4416c5319ef51d1a751b367a3e37d1f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
