Ryan Harper has posted comments on this change.
Change subject: BZ#856167 - Verify downloaded CA certificate
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1510: logging.debug("getRhevmCert: the string \"%s\" is not a
valid X.509 certificate" % rhevmCert)
Line 1511: return False
Line 1512: finally:
Line 1513: if tmpPath:
Line 1514: os.remove(tmpPath)
a tempfile.NamedTemporaryFile with delete=true does most of the work here
including open and delete on close.
http://docs.python.org/library/tempfile.html
Line 1515:
Line 1516: # Now that we know that it is a valid certificate save it to its
definitive
Line 1517: # location:
Line 1518: dirName = os.path.dirname(CACERT)
--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
