Alon Bar-Lev has posted comments on this change. Change subject: BZ#856167 - Validate downloaded CA certificate ......................................................................
Patch Set 4: Juan, See[1]. In any update of production file, I prefer to to write it with $FILE.suffix, then move($FILE.suffix, $FILE). As mv is atomic you always get either new or old file, and you do not experience issues such as filesystem full, partial write. This is just safe guard... [1] https://bugzilla.redhat.com/show_bug.cgi?id=822953#c14 -- To view, visit http://gerrit.ovirt.org/8021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
