Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/vdsm-config
Line 71: done
Line 72: echo "checkpoint 2 ::management_server:
$managment_server" >> $LOG 2>&1
Line 73:
Line 74: if [ ! -z "$managment_server" ]; then
Line 75: if [[ "$managment_server" == *:* ]]; then
Are we sure we want to enforce bash?
Line 76:
vdc_managment_server=${managment_server%:*}
Line 77:
vdc_managment_port=${managment_server#*:}
Line 78: else
Line 79: vdc_managment_server=${managment_server}
--
To view, visit http://gerrit.ovirt.org/8022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74d658902d3421c0ac554c5c2634ddc8c6a28b21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
