Dan Kenigsberg has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_reg/vdsm-config
Line 75: case "${managment_server}" in
Line 76: *:*)
Line 77:
vdc_managment_server="${managment_server%:*}"
Line 78:
vdc_managment_port="${managment_server#*:}"
Line 79: ;
is the single semicolon intentional?
Line 80: *)
Line 81:
vdc_managment_server="${managment_server}"
Line 82: vdc_managment_port=443
Line 83: ;;
--
To view, visit http://gerrit.ovirt.org/8022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74d658902d3421c0ac554c5c2634ddc8c6a28b21
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
