Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm_reg/vdsm-upgrade
Line 154: else:
Line 155: msg = "<BSTRAP component='RHEV_INSTALL' status='OK'/>"
Line 156: logging.debug("<BSTRAP component='RHEV_INSTALL'
status='OK'/>")
Line 157: # Stop vdsm to avoid any communication with Engine before the
reboot happens
Line 158: deployUtil._logExec([constants.EXT_SERVICE, 'vdsmd', 'stop'])
Sorry to be so bad...
I rather doing this before script returns FAIL or OK, as the stop may also fail
and take time to complete...
We also need to test for status before stop, so we detect failure in actual
stop.
Line 159:
Line 160: print (msg)
Line 161:
Line 162: sys.stdout.flush()
--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
