Alon Bar-Lev has posted comments on this change. Change subject: vdsm-upgrade: stop vdsm when complete upgrade ......................................................................
Patch Set 3: (2 inline comments) Thanks! .................................................... File vdsm_reg/vdsm-upgrade Line 133: # Checking the current status of vdsm Line 134: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 'vdsmd', 'status']) Line 135: if ret == 0: Line 136: # Stop vdsm to avoid any communication with Engine before the reboot happens Line 137: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 'vdsmd', 'stop']) More important to check this return code... if we fail to stop we should fail the entire process. Line 138: else: Line 139: msg = "<BSTRAP component='RHEL_INSTALL' status='FAIL' message='vdsm daemon" \ Line 140: " is down before we stop it for upgrade, please verify!'/>" Line 141: logging.debug(msg) Line 138: else: Line 139: msg = "<BSTRAP component='RHEL_INSTALL' status='FAIL' message='vdsm daemon" \ Line 140: " is down before we stop it for upgrade, please verify!'/>" Line 141: logging.debug(msg) Line 142: print(msg) Not sure this is important... if vdsm is stopped, so be it... what exactly is the problem? Line 143: Line 144: try: Line 145: config.read(VDSM_REG_CONF_FILE) Line 146: -- To view, visit http://gerrit.ovirt.org/8029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
