ShaoHe Feng has posted comments on this change.
Change subject: [WIP]add mem cgroup support to vdsm
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5113: # Since: 4.10.0
Line 5114: ##
Line 5115: {'type': 'TuneMemParams',
Line 5116: 'data': {'hard_limit': 'uint', 'soft_limit': 'uint',
Line 5117: 'min_gurantee': 'uint'}}
a tab here?
Line 5118: ##
Line 5119: # @VM.tuneMem:
Line 5120: #
Line 5121: # Tune memory hard limits and min allocation guranteed.
....................................................
File vdsm_cli/vdsClient.py
Line 210: if len(args) > 1:
Line 211: for param in args[1:]:
Line 212: if '=' in param:
Line 213: key, value = line.split("=", 1)
Line 214: params[key] = value
_eqSplit is defined in this code, it can be used here. and an error param in
args, it can raise ValueError
Line 215: return self.ExecAndExit(self.s.tuneMem(params))
Line 216:
Line 217: def hotplugNic(self, args):
Line 218: nic = self._parseDriveSpec(args[1])
--
To view, visit http://gerrit.ovirt.org/8031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ad220e21b114985ead4bd64e81133173566444
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
