Doron Fediuck has posted comments on this change.
Change subject: [WIP]add mem cgroup support to vdsm
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Royce,
Please see inline.
Also, the API is a bit misleading because of how libvirt handles it, since the
amounts specified, includes not only guest ram, but other qemu ram also being
used:
For QEMU/KVM, the parameters are applied to the QEMU process as a whole. Thus,
when counting them, one needs to add up guest RAM, guest video RAM, and some
memory overhead of QEMU itself. The last piece is hard to determine so one
needs guess and try.
So please add it to the API documentation, so people are aware of it.
....................................................
File vdsm_cli/vdsClient.py
Line 1813: )),
Line 1814: 'tuneMem': (serv.tuneMem,
Line 1815: ('<vmId>'
Line 1816: '[hard_limit=value soft_limit=value
min_gurantee]',
Line 1817: 'Parameters list: r=required, o=optional',
Please specify which units are being used here.
Line 1818: 'r vmId: The vm to be tuned',
Line 1819: 'o hard_limit=<value>: '
Line 1820: 'maximum memory the VM can use(in KiB)',
Line 1821: 'o soft_limit=<value>:'
Line 1820: 'maximum memory the VM can use(in KiB)',
Line 1821: 'o soft_limit=<value>:'
Line 1822: 'memory limit to enforce during memory
contention',
Line 1823: 'o min_gurantee=<value>:'
Line 1824: 'min memory guranteed to the VM',
The r-o-o-o combination may need to change;
ie- what happens if I only give vmId with nothing else? which tuning will take
place?
Line 1825: 'Tune memory hard limits and min allocation
gurantee'
Line 1826: )),
Line 1827: 'migrate': (serv.do_migrate,
Line 1828: ('vmId=<id> method=<offline|online>
src=<host:[port]> '
--
To view, visit http://gerrit.ovirt.org/8031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ad220e21b114985ead4bd64e81133173566444
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
