Ramesh N has posted comments on this change. Change subject: gluster: fix performance issue in brick creation ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/47959/3/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 73: if unitType == 'KiB': Line 74: return device.size.convertTo(spec='KiB') Line 75: else: Line 76: return device.size.convertTo(spec='MiB') Line 77: return 0 > Is this related to the changes described in the commit message? If not, ple I have splited this to different patch at https://gerrit.ovirt.org/50705. Line 78: Line 79: Line 80: def _getDeviceDict(device, createBrick=False): Line 81: info = {'name': device.name, -- To view, visit https://gerrit.ovirt.org/47959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Manoj Pillai <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
