Nir Soffer has posted comments on this change. Change subject: gluster: fix performance issue in brick creation ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/47959/6//COMMIT_MSG Commit Message: Line 12: 1. PVs should be created directly on the disks instead of Line 13: MBR partitions to align the pvs correctly as per given Line 14: RAID parameter. This patch will remove the _makePartition Line 15: function and will not create parition as part of Line 16: gluster brick creation So previously we were creating partition table that nobody needed, because this what blivet api does? Line 17: Line 18: 2. Mount options "inode64,noatime" should be used always Line 19: Line 20: 3. chunk size and alignment value should be 256KB for Line 14: RAID parameter. This patch will remove the _makePartition Line 15: function and will not create parition as part of Line 16: gluster brick creation Line 17: Line 18: 2. Mount options "inode64,noatime" should be used always Why? What was used before this patch? Line 19: Line 20: 3. chunk size and alignment value should be 256KB for Line 21: JBOD use case. As a result of this, we end of using Line 22: lvm commands instead of blivet APIs to create PV, Line 19: Line 20: 3. chunk size and alignment value should be 256KB for Line 21: JBOD use case. As a result of this, we end of using Line 22: lvm commands instead of blivet APIs to create PV, Line 23: Thin pool, VG. Why 256KB? What you used before this patch? This looks like 3 logic changes to me, any reason why they are must be done together in the same patch? Line 24: Line 25: Bug-Url: https://bugzilla.redhat.com/1270792 Line 26: Signed-off-by: Ramesh Nachimuthu <[email protected]> Line 27: Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 -- To view, visit https://gerrit.ovirt.org/47959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Manoj Pillai <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
