Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
......................................................................
Patch Set 2: (3 inline comments)
Looks fine, but please explain my questions first.
....................................................
File vdsm/vdsmd.init.in
Line 38: QCONF=/etc/libvirt/qemu.conf
Line 39: LDCONF=/etc/sysconfig/libvirtd
Line 40: QLCONF=/etc/libvirt/qemu-sanlock.conf
Line 41:
Line 42: is_coredump=`/usr/bin/vdsm-tool get-conf-item $CONF_FILE vars
core_dump_enable false`
1. Could it be better we let
GETCONFITEM="/usr/bin/vdsm-tool get-conf-item"
then we can use $GETCONFITEM as usual?
2. Why drop the "tr A-Z a-z"? I think this is for change big capitalized "True"
and "False" to "true" and "false".
Line 43: [ $is_coredump != true ] && is_coredump=false
Line 44:
Line 45: SYSTEMCTL_SKIP_REDIRECT=true
Line 46:
Line 109:
Line 110: test_conflicting_conf() {
Line 111: local listen_tcp auth_tcp ssl
Line 112:
Line 113: ssl=`/usr/bin/vdsm-tool get-conf-item $CONF_FILE vars ssl true`
Same as line 42
Line 114: [ "$ssl" == true ] && return 0
Line 115:
Line 116: listen_tcp="`get_libvirt_conf_item $LCONF listen_tcp`"
Line 117: auth_tcp="`get_libvirt_conf_item $LCONF auth_tcp`"
Line 249: ovirt_store_config() { :; }
Line 250: fi
Line 251:
Line 252: local lconf qconf ldconf
Line 253: local ssl=`/usr/bin/vdsm-tool get-conf-item $CONF_FILE vars ssl
true`
Same as line 42.
Line 254:
Line 255: lconf="$2"
Line 256: qconf="$3"
Line 257: ldconf="$4"
--
To view, visit http://gerrit.ovirt.org/7695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c64de097bbaea6a8cf862b43243377e10e00391
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
