Zhou Zheng Sheng has posted comments on this change. Change subject: move get-conf-item/set-conf-item to vdsm-tool ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 38: QCONF=/etc/libvirt/qemu.conf Line 39: LDCONF=/etc/sysconfig/libvirtd Line 40: QLCONF=/etc/libvirt/qemu-sanlock.conf Line 41: Line 42: is_coredump=`/usr/bin/vdsm-tool get-conf-item $CONF_FILE vars core_dump_enable false` 2. I see get-conf-item.py changes boolean value to lower case. Fine. Line 43: [ $is_coredump != true ] && is_coredump=false Line 44: Line 45: SYSTEMCTL_SKIP_REDIRECT=true Line 46: -- To view, visit http://gerrit.ovirt.org/7695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c64de097bbaea6a8cf862b43243377e10e00391 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
