Ido Barkan has posted comments on this change. Change subject: hooks: ovs: show vlan in caps ports ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/50730/5/vdsm_hooks/ovs/ovs_after_get_caps.py File vdsm_hooks/ovs/ovs_after_get_caps.py: Line 75: _get_ports this is a little complicated. can you add a doc string? what should _list_ports return in the cases of top_device? Line 80: _list_ports can _list_ports return duplicates? if not, this is a little more confusing then: if x not in l: l.append(x) -- To view, visit https://gerrit.ovirt.org/50730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
