Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: show vlan in caps ports
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/50730/10/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 233:                             hostQos=None, 
assert_in_running_conf=True):
Line 234:         netinfo = self.vdsm_net.netinfo
Line 235:         running_config = self.vdsm_net.config
Line 236:         network_config = running_config.networks[networkName]
Line 237:         network_netinfo = netinfo.networks[networkName]
unrelated but could we keep it?
Line 238:         self.assertIn(networkName, netinfo.networks)
Line 239:         if bridged is not None:
Line 240:             self.assertEqual(bridged, network_netinfo['bridged'])
Line 241:             if bridged:


-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to