Shu Ming has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/remoteFileHandler.py
Line 184: # If for some reason the connection drops\gets out of
sync we treat
Line 185: # it as a timeout so we only have one error path
Line 186: self.log.warn("Problem with handler, treating as timeout",
Line 187: exc_info=True)
Line 188: raise Timeout()
Is it an unnecessary Timeout exception raising here after the change above?
Line 189:
Line 190: res, err = pickle.loads(rawResponse)
Line 191: if err is not None:
Line 192: raise err
--
To view, visit http://gerrit.ovirt.org/6671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie32aa474d3ab9ec455c15415df20b749d54e5658
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
