Dan Kenigsberg has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
......................................................................
Patch Set 7: Verified
(1 inline comment)
I did *not* verify this, but this seems safe enough to me, and would provide
more meaningful tracebacks in the log file.
....................................................
File vdsm/storage/remoteFileHandler.py
Line 181: except Timeout:
Line 182: raise
Line 183: except:
Line 184: # If for some reason the connection drops\gets out of
sync we treat
Line 185: # it as a timeout so we only have one error path
so maybe a more generic exception name would be a good idea.
Line 186: self.log.warn("Problem with handler, treating as timeout",
Line 187: exc_info=True)
Line 188: raise Timeout()
Line 189:
--
To view, visit http://gerrit.ovirt.org/6671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie32aa474d3ab9ec455c15415df20b749d54e5658
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
