Dan Kenigsberg has posted comments on this change.
Change subject: Do not propagate the bridge bootproto to the underlying devices.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
I'm all for quick and dirty. However, in my opinion a cleaner approach would be
to not pass this "option" trash bag down the stack (future).
....................................................
File vdsm/configNetwork.py
Line 904: # only on most top device according to following order:
Line 905: # bridge -> vlan -> bond -> nic
Line 906: # For lower level devices we should ignore it.
Line 907: # reset ip, netmask, gateway for lower level devices
Line 908: bridgeBootproto = options.get('bootproto')
I don't think think this is anyhow related to bridge-ness of the network. (see
line 928)
Line 909: ipaddr = netmask = gateway = options['bootproto'] = None
Line 910:
Line 911: # For VLAN we should attach bridge only to the VLAN device
Line 912: # rather than to underlying NICs or bond
--
To view, visit http://gerrit.ovirt.org/8058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd308c6db11d8641ecee84817c5f0b9d6e5eaf74
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
