Igor Lvovsky has posted comments on this change.
Change subject: Do not propagate the bridge bootproto to the underlying devices.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 905: # bridge -> vlan -> bond -> nic
Line 906: # For lower level devices we should ignore it.
Line 907: # reset ip, netmask, gateway for lower level devices
Line 908: bridgeBootproto = options.get('bootproto')
Line 909: ipaddr = netmask = gateway = options['bootproto'] = None
Toni, Dan is right it's not related to bridgeness.
You need to reset 'bootproto' for every underlying interfaces ones you set it
for top layer device.
Think if you have a bridgeless VLANed network , you will need to set bootproto
only on vlan device but not on underlying bond/nic
Line 910:
Line 911: # For VLAN we should attach bridge only to the VLAN device
Line 912: # rather than to underlying NICs or bond
Line 913: brName = network if bridged else None
--
To view, visit http://gerrit.ovirt.org/8058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd308c6db11d8641ecee84817c5f0b9d6e5eaf74
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
