Ryan Harper has posted comments on this change. Change subject: Validate downloaded CA certificate ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm_reg/deployUtil.py.in Line 124: if input is not None: Line 125: logging.debug(input) Line 126: stdin = subprocess.PIPE Line 127: p = subprocess.Popen(argv , stdin=stdin, stdout=subprocess.PIPE, stderr=subprocess.PIPE) Line 128: out, err = p.communicate(input) This seems unrelated to the original patch purpose, please separate this out into a separate patch and make your validation depend on this change. Line 129: rc = p.returncode Line 130: logging.debug(out) Line 131: logging.debug(err) Line 132: except: -- To view, visit http://gerrit.ovirt.org/8021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
