Tal Nisan has posted comments on this change. Change subject: Added the option to scan alignment directly according to a config value ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40402/5//COMMIT_MSG Commit Message: Line 4: Commit: Tal Nisan <tni...@redhat.com> Line 5: CommitDate: 2015-12-30 17:03:04 +0200 Line 6: Line 7: Added the option to scan alignment directly according to a config value Line 8: > can you explain why is this good for? Currently there is a problem with Libguestfs/Libvirt with alignment scans so the only option for us is to scan via Libguestfs directly without it going through Libvirt. Since we allow those scans only on powered down VMs it poses no problem since the only problem can occur on a powered up VM in which doing the scan not through Libvirt will mark the VM as tainted so basically we are 100% covered with scanning directly. But just in case the PMs wanted us to make it configurable in case a customer would not like the scan to be direct for some reason, hence the config value Line 9: Bug-Url: https://bugzilla.redhat.com/1151838 Line 10: Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d -- To view, visit https://gerrit.ovirt.org/40402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches