Nir Soffer has posted comments on this change. Change subject: nettestlib: use cpuarch module ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49992/4/tests/nettestlib.py File tests/nettestlib.py: Line 154: Line 155: _IFF_TAP = 0x0002 Line 156: _IFF_NO_PI = 0x1000 Line 157: arch = cpuarch.real() Line 158: if cpuarch.is_x86(arch): > Is this true for x86? the original code checked for x86_64. When you do suc If this change is correct, please separate it to different patch, like you did with the the next patch adding support for ppc64le. (general rule - separate refactoring from behavior changes). Line 159: _TUNSETIFF = 0x400454ca Line 160: elif arch == cpuarch.PPC64: Line 161: _TUNSETIFF = 0x800454ca Line 162: else: -- To view, visit https://gerrit.ovirt.org/49992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacb382c2abcbc4e1e7a3d9423b1814b64409ed8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
