Nir Soffer has posted comments on this change.

Change subject: nettestlib: use cpuarch module
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/49992/7/tests/nettestlib.py
File tests/nettestlib.py:

Line 155: 
Line 156:     _IFF_TAP = 0x0002
Line 157:     _IFF_NO_PI = 0x1000
Line 158:     arch = cpuarch.real()
Line 159:     if cpuarch.is_x86(arch):
> I concur with your explanation, but I also believe that
I agree with Francesco.
Line 160:         _TUNSETIFF = 0x400454ca
Line 161:     elif arch == cpuarch.PPC64:
Line 162:         _TUNSETIFF = 0x800454ca
Line 163:     else:


-- 
To view, visit https://gerrit.ovirt.org/49992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idacb382c2abcbc4e1e7a3d9423b1814b64409ed8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to