Milan Zamazal has posted comments on this change. Change subject: lib: avoid circular references due to wrapping ......................................................................
Patch Set 2: Making an object uncollectable (by having __del__ and reference to itself in it) is a problem that should be fixed, although we certainly should know why we lose the connections. As for the "uncollectable" part of the fix, why do we use the wrappers and don't we use simply __getattr__ like in virdomain.Notifying? (Real) performance reasons? Or something else worth the complications? -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
