Francesco Romani has posted comments on this change. Change subject: lib: avoid circular references due to wrapping ......................................................................
Patch Set 2: Thanks fro the reviews. This is indeed an early attempt (as the "Draft" status suggests) to hunt down leaks. I can reproduce quite easily virDomain being uncollectable, and being part of a reference cycle and this is part of the fix. Didn't had the chance to run my full reproducer yet, will do ASAP. I agree the getattr() approach seems better, but we need a fix backportable to 3.6 and maybe even 3.5, let's take this in account. -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
