Saggi Mizrahi has posted comments on this change. Change subject: supervdsmServer is down after failed operation ......................................................................
Patch Set 6: I would prefer that you didn't submit this (3 inline comments) .................................................... Commit Message Line 7: supervdsmServer is down after failed operation Line 8: Line 9: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=846307 Line 10: Line 11: After running operation that throws exception that we don't catch in throws an exception Line 12: supervdsmServer, we catch it in ProxyCaller::__call__ method. Line 13: In this except code we reset supervdsmServer and call the same method Line 14: again. Line 15: If the exception is thrown again, we leave supervdsmServer down And this .................................................... File vdsm/supervdsm.py Line 61: def __call__(self, *args, **kwargs): Line 62: callMethod = lambda: \ Line 63: getattr(self._supervdsmProxy._svdsm, self._funcName)(*args, Line 64: **kwargs) Line 65: if self._supervdsmProxy.isSupervdsmUp(): If not ....: self._supervdsmProxy.restartSupervdsm() return .... Line 66: return callMethod() Line 67: else: Line 68: self._supervdsmProxy.restartSupervdsm() Line 69: return callMethod() .................................................... File vdsm/utils.py Line 852: Line 853: def __unicode__(self): Line 854: return unicode(self.cmd) Line 855: Line 856: def getProcessUpTimeByPID(pid): reuse the one in misc Line 857: try: Line 858: uptime = os.stat('/proc/' + str(pid)).st_mtime Line 859: return uptime Line 860: except Exception as e: -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
