Saggi Mizrahi has posted comments on this change.

Change subject: supervdsmServer is down after failed operation
......................................................................


Patch Set 9: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 83:                         self._authkey, str(os.getpid())]
Line 84:         misc.execCmd(superVdsmCmd, sync=False, sudo=True)
Line 85:         sleep(2)
Line 86: 
Line 87:     def isSupervdsmUp(self):
isRunnning() is sufficient as it's a member method of the superVDSM object
Line 88:         try:
Line 89:             with open(PIDFILE, "r") as f:
Line 90:                 spid = int(f.readline().strip())
Line 91:                 createdTime = int(f.readline().strip())


--
To view, visit http://gerrit.ovirt.org/7901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to