Peter V. Saveliev has posted comments on this change. Change subject: add "uptime" field to the getStats (getVdsStats in vdsClient) call ......................................................................
Patch Set 2: (2 inline comments) .................................................... Commit Message Line 6: Line 7: add "uptime" field to the getStats (getVdsStats in vdsClient) call Line 8: Line 9: "uptime" field, measured in seconds, contains VDSM run time since Line 10: start, actually -- since first API.py import Engine, maybe, does not need it, it was invented for testing purposes and post-mortem analysis. No, generationID is not enough, as it doesn't store uptime information, we can only know from it that VDSM was (or was not) restarted. Nor how much times it was restarted, neither how long time it runs already. The reason of «uptime» field was just the same as the system uptime, and the next step would be some simple and reliable analogue of wtmp and last -x for VDSM. Line 11: Line 12: Signed-off-by: Peter V. Saveliev <[email protected]> .................................................... File vdsm/API.py Line 1102: stats['memShared'] = self._memShared() / Mbytes Line 1103: Line 1104: stats['netConfigDirty'] = str(self._cif._netConfigDirty) Line 1105: stats['generationID'] = self._cif._generationID Line 1106: stats['uptime'] = time.time() - STARTTIME Will it be enough, if starttime will be implemented as APIBase or ClientIF static member? Line 1107: return {'status': doneCode, 'info': stats} Line 1108: Line 1109: def setLogLevel(self, level): Line 1110: """ -- To view, visit http://gerrit.ovirt.org/8008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc998117e25faff17c2f3f6d66e2a961fc93e029 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
