Saggi Mizrahi has posted comments on this change.
Change subject: Fix problems with current implementation of forceIscsiRescan
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 292: self.__validateLvmLockingType()
Line 293:
Line 294: def storageRefresh():
Line 295: lvm._lvminfo.bootstrap()
Line 296: iscsiRescanTimeout = config.getint('irs',
'scsi_rescan_timeout')
Generally, the main class should be the only place you read configuration.
But VDSM is a frankenstine's monster and is made up of 3 main classes.
ClientIF, HSM, and whatever MOM uses. So those classes are the only places you
should read the config.
In general, I'd even prefer it being read (and validated) only in the ctor. but
one step at a time.
Line 297: if (iscsiRescanTimeout < 0):
Line 298: self.log.warning("scsi_rescan_timeout as an invalid
value, "
Line 299: "using the default: %d",
Line 300: sdCache.iscsiRescanTimeout)
--
To view, visit http://gerrit.ovirt.org/8172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e7173086ba15c7706206c5ee1473ed6d334f9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
