Yaniv Bronhaim has posted comments on this change.
Change subject: Fix problems with current implementation of forceIscsiRescan
......................................................................
Patch Set 4: No score
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 296: iscsiRescanTimeout = config.getint('irs',
'scsi_rescan_timeout')
Line 297: if (iscsiRescanTimeout < 0):
Line 298: self.log.warning("scsi_rescan_timeout as an invalid
value, "
Line 299: "using the default: %d",
Line 300: sdCache.iscsiRescanTimeout)
I guess you should not continue here and assign negative value to
rescanTimeout. I'd continue with the default value and log print, but notice
that you print here the default value instead of the config value.. change it
Line 301:
Line 302: sdCache.iscsiRescanTimeout = iscsiRescanTimeout
Line 303: sdCache.refreshStorage()
Line 304:
--
To view, visit http://gerrit.ovirt.org/8172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e7173086ba15c7706206c5ee1473ed6d334f9e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Rami Vaknin <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
