Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG Commit Message: Line 7: lun: Serial attr should not passed to libvirt for lun disks. Line 8: Line 9: Following the change which was introduced at Line 10: libvirt-1.2.17-5 and qemu-kvm-rhev-2.3.0-18, libvirt now enforce Line 11: that a scsi-block 'lun' device should not provide the 'serial' property. > For EL7 we require libvirt-1.2.8-16.el7_1.4. So this behavior should either Will change the commit message as mentioned above. Still trying to verify this on ibvirt-0.10.2-54.el6_7.2.x86_64 Line 12: Line 13: To comply with this change, this patch introduces a change Line 14: that a VM should ignore 'serial' property for lun devices when Line 15: passing the XML to libvirt. Line 18: had enabled SCSI Pass-Through and also plugging the same lun disk Line 19: while the VM was running. The operation succeeded. Line 20: Line 21: Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83 Line 22: Bug-Url: https://bugzilla.redhat.com/1291930 > You should use the 3.5.z bug - https://bugzilla.redhat.com/1299235 Done Line 23: Signed-off-by: Maor Lipchuk <[email protected]> Line 24: Tested-by: Maor Lipchuk <[email protected]> Line 25: Reviewed-on: https://gerrit.ovirt.org/51766 Line 26: Continuous-Integration: Jenkins CI -- To view, visit https://gerrit.ovirt.org/52463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
