Allon Mureinik has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. ......................................................................
Patch Set 2: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/52463/2//COMMIT_MSG Commit Message: Line 13: To comply with this change, this patch introduces a change Line 14: that a VM should ignore 'serial' property for lun devices when Line 15: passing the XML to libvirt. Line 16: Line 17: Since the serial attribute is basically redundant for lun devices Please remove the TLS here Line 18: it was also removed for EL6 hosts which are used in oVirt 3.5 Line 19: Line 20: This patch was verified by running a VM with lun disk which Line 21: has enabled SCSI Pass-Through and also plugging the same lun disk -- To view, visit https://gerrit.ovirt.org/52463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
