Francesco Romani has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/52463/4/tests/vmTests.py File tests/vmTests.py: Line 851: zip(devConfs, expectedXMLs, blockDevs, vmConfs): Line 852: drive = vm.Drive(vmConf, self.log, **devConf) Line 853: # Patch Drive.blockDev to skip the block device checking. Line 854: drive._blockDev = blockDev Line 855: xmlForCompare = xml if devConf['device'] == 'lun' else xml % SERIAL I expect this to raise a TypeError for not-lun devices, when we use the last expectedXML, without the serial attribute, like: >>> print "a=a" % "42" Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: not all arguments converted during string formatting >>> Line 856: self.assertXML(drive.getXML(), xmlForCompare) Line 857: Line 858: def testIoTuneException(self): Line 859: SERIAL = '54-a672-23e5b495a9ea' -- To view, visit https://gerrit.ovirt.org/52463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
