Francesco Romani has posted comments on this change. Change subject: vdsm: move fake_kvm code into faqemu ......................................................................
Patch Set 18: Code-Review+1 (2 comments) looks good, but a couple of suggestion in the hook. Partial ACK for this reason. https://gerrit.ovirt.org/#/c/46897/18/vdsm_hooks/faqemu/after_get_caps.py File vdsm_hooks/faqemu/after_get_caps.py: Line 46: 'rhel6.0.0', Line 47: 'rhel6.5.0'] Line 48: Line 49: Line 50: if __name__ == '__main__': please move the body of this if: into a function Line 51: if config.getboolean('vars', 'fake_kvm_support'): Line 52: caps = hooking.read_json() Line 53: arch = config.get('vars', 'fake_kvm_architecture') Line 54: Line 72: elif cpuarch.is_ppc(arch): Line 73: caps['cpuModel'] = 'POWER 8(fake)' Line 74: caps['cpuFlags'] = 'powernv,model_POWER8' Line 75: else: Line 76: raise RuntimeError('Unsupported architecture: %s' % arch) raise cpuarch.UnsupportedArchitecture(arch) ? Line 77: -- To view, visit https://gerrit.ovirt.org/46897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches