Zhou Zheng Sheng has posted comments on this change.
Change subject: avoid creating hangover in storage domain cache after formatting
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2197: try:
Line 2198: sdCache.manuallyRemoveDomain(dom.sdUUID)
Line 2199: except KeyError:
Line 2200: self.log.warn("Storage domain %s doesn't exist in
cache. "
Line 2201: "Trying recycle leftovers ...",
dom.sdUUID)
Ah, that's true, thanks. I have to add a comment to warn other people about
this, maybe I can delete the binding to "dom" variable.
Line 2202:
Line 2203:
Line 2204: @public
Line 2205: def formatStorageDomain(self, sdUUID, autoDetach = False,
options = None):
--
To view, visit http://gerrit.ovirt.org/8144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13a97ad6830553cbd099189dfb82d6f02ce82fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
