Vinzenz Feenstra has posted comments on this change.
Change subject: avoid creating hangover in storage domain cache after formatting
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2294: try:
Line 2295: sdCache.manuallyRemoveDomain(sdUUID)
Line 2296: except KeyError:
Line 2297: self.log.warn("Storage domain %s doesn't exist in
cache. "
Line 2298: "Trying recycle leftovers ...", sdUUID)
This log message implies that there would be done something afterwards, but
this is no longer the case.
Please adjust the log message. Thank you.
Line 2299:
Line 2300:
Line 2301: @public
Line 2302: def formatStorageDomain(self, sdUUID, autoDetach = False,
options = None):
--
To view, visit http://gerrit.ovirt.org/8144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13a97ad6830553cbd099189dfb82d6f02ce82fe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
