Milan Zamazal has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g ......................................................................
Patch Set 1: (2 comments) Nice change! Just a question about using @property. https://gerrit.ovirt.org/#/c/52882/1//COMMIT_MSG Commit Message: Line 10: it's ... its ... https://gerrit.ovirt.org/#/c/52882/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3732: @property Line 3733: def name(self): Line 3734: return self.conf['vmName'] Line 3735: Line 3736: @property I wonder about relative popularity of properties in Vdsm. IMHO they have typically only drawbacks: - They are confused with attributes. - Arguments can't be added to their invocations. I've always thought about properties mostly as a means to handle legacy or library code, when attribute access must be customized without changing the original code or its interface. So what's the motivation to use properties in situations like this one? Line 3737: def xml(self): Line 3738: return self._dom.XMLDesc(0) Line 3739: Line 3740: def _getPid(self): -- To view, visit https://gerrit.ovirt.org/52882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic159cb84049d90cdb2a4279a34145462c8ee6be4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
