Francesco Romani has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52882/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3732: @property Line 3733: def name(self): Line 3734: return self.conf['vmName'] Line 3735: Line 3736: @property > the flags argument to XMLDesc it is opional, so we really should not use it I agree about using Vm.domain.xml. Every XML access should be mediated by DomainDescriptor (usual caveat: unless there is a really exceptional situation). We talked about this back in the office; so, what we need is: 1. in migration.py, s/vm._dom.XMLDesc(0)/vm.domain.xml/g 2. make sure the domain xml is up to date each time we use it in migration.py. If this is not the case, call updateDomainDescriptor() wherever needed 3. (in another patch?) maybe make updateDomainDescriptor return the current, just updated. xml. Line 3737: def xml(self): Line 3738: return self._dom.XMLDesc(0) Line 3739: Line 3740: def _getPid(self): -- To view, visit https://gerrit.ovirt.org/52882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic159cb84049d90cdb2a4279a34145462c8ee6be4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
