Dan Kenigsberg has submitted this change and it was merged. Change subject: glusterHostsList verb returns local hostname as IP address or FQDN ......................................................................
glusterHostsList verb returns local hostname as IP address or FQDN The verb glusterHostsList executes the 'gluster peer status' command to fetch list of servers of the gluster cluster. However the output of this command doesn't include the server on which the command is being executed. For completeness the verb appends current server detail to the list given by gluster When hostname of the current server is used in the detail, the problem with hostname is that what's saved in engine db in the host_name field is not necessarily the actual hostname of the host, but whatever user entered while adding the host, which could be ip address also. So engine can't rely on the hostname, particularly on compare the list returned by the glusterHostsList verb with the list of hosts present in engine DB to identify if something has changed because of direct cli operations from the gluster cli. So this patch enables sending an ip address instead of hostname of the current server. Engine db contains all ip addresses of the server, and hence ip address can be used for comparisons. Change-Id: I24d2b4d27107d208672b1d3df96dd7759d2288c5 Signed-off-by: Bala.FA <[email protected]> --- M vdsm/gluster/cli.py 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Bala.FA: Verified Shireesh Anjal: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24d2b4d27107d208672b1d3df96dd7759d2288c5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
