Martin Betak has posted comments on this change. Change subject: vdsm: Remove unreachable code ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/52980/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 294 Line 295 Line 296 Line 297 Line 298 ureachable since we either return or raise before getting to this line. https://gerrit.ovirt.org/#/c/52980/1/tests/schemaValidationTest.py File tests/schemaValidationTest.py: Line 110 Line 111 Line 112 Line 113 Line 114 raise prevents the execution to reach this line https://gerrit.ovirt.org/#/c/52980/1/vdsm/API.py File vdsm/API.py: Line 255 Line 256 Line 257 Line 258 Line 259 dominated by above return https://gerrit.ovirt.org/#/c/52980/1/vdsm_hooks/hugepages/before_vm_migrate_destination.py File vdsm_hooks/hugepages/before_vm_migrate_destination.py: Line 51 Line 52 Line 53 Line 54 Line 55 unreachable due to the presence of sys.exit above -- To view, visit https://gerrit.ovirt.org/52980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
