Milan Zamazal has posted comments on this change. Change subject: vdsm: Remove unreachable code ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Good idea, just an objection about modifying the hook. https://gerrit.ovirt.org/#/c/52980/1/vdsm_hooks/hugepages/before_vm_migrate_destination.py File vdsm_hooks/hugepages/before_vm_migrate_destination.py: Line 51 Line 52 Line 53 Line 54 Line 55 > unreachable due to the presence of sys.exit above Unlike the other cases that piece of code is probably left intentionally here for reference, so it shouldn't be touched or it should be handled outside this patch. -- To view, visit https://gerrit.ovirt.org/52980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
