Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 401: # this workaround should be removed.
Line 402:
Line 403: for i in {1..50}
Line 404: do
Line 405: if virsh -r version > /dev/null 2>&1 &&
If we are going to use virsh, we might want to add to spec file libvirt-client
require. Also, I understood that virsh is a valid/nice tool to check if libvirt
is running, however I have seen in the past virsh segmentation fault errors..
we want to depend of external tool/component to check if libvirt is up instead
of checking the socket file? (just question)
Line 406: pgrep libvirtd > /dev/null 2>&1; then
Line 407: return 0
Line 408: fi
Line 409: sleep 0.2
--
To view, visit http://gerrit.ovirt.org/8245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2844070ca0816525851b3b495b3dfe3096058a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
