Rami Vaknin has posted comments on this change.

Change subject: vdsm: Use virsh to check if libvirt is up
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 401:     # this workaround should be removed.
Line 402: 
Line 403:     for i in {1..50}
Line 404:     do
Line 405:         if virsh -r version > /dev/null 2>&1; then
I would use absolute path: /usr/bin/virsh
Line 406:             return 0
Line 407:         fi
Line 408:         sleep 0.2
Line 409:     done


--
To view, visit http://gerrit.ovirt.org/8245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2844070ca0816525851b3b495b3dfe3096058a9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Rami Vaknin <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to