Yaniv Bronhaim has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-01-28 15:10:47 +0100 Line 4: Commit: pkliczewski <[email protected]> Line 5: CommitDate: 2016-02-05 13:56:09 +0100 Line 6: Line 7: contrib: schema converter you moved the parsing code. why? Line 8: Line 9: Line 10: Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 https://gerrit.ovirt.org/#/c/52864/2/contrib/schema-converter File contrib/schema-converter: Line 323: # make sure that types are first Line 324: data = commands Line 325: data['types'] = all_types Line 326: Line 327: f.write(yaml.dump(data, indent=4, width=80, default_flow_style=False, Dumper=Anchor)) pep8 violation Line 328: Line 329: Line 330: def main(args): Line 331: if len(args) < 2: Line 336: yaml_path = args[1] Line 337: Line 338: api = vdsmapi.get_api(json_path) Line 339: Line 340: with open(json_path) as f: check if it works with python3 coding . I needed to use io.open and specify encoding type when reading conf file Line 341: symbols = vdsmapi.read_schema_doc(f, api) Line 342: Line 343: with open(yaml_path, 'w') as f: Line 344: write_schema(f, symbols) -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
