Yaniv Bronhaim has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-01-28 15:10:47 +0100 Line 4: Commit: pkliczewski <[email protected]> Line 5: CommitDate: 2016-02-05 13:56:09 +0100 Line 6: Line 7: contrib: schema converter > the name is used during build and it was intentionally created in that way. so say it here, or do it separately . I'd rename the module name. dan will never merge patch that says schema converter which also moves 100+ lines of code Line 8: Line 9: Line 10: Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
