Bala.FA has posted comments on this change. Change subject: Added glusterVolumeTop verb ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-09-06 19:33:25 +0530 Line 4: Commit: Timothy Asir <[email protected]> Line 5: CommitDate: 2012-09-17 12:37:50 +0530 Line 6: Line 7: Added glusterVolumeTop verb Add better commit message and explain each verb separately Line 8: Line 9: Added glusterVolumeTopOpen verb Line 10: Added glusterVolumeTopRead verb Line 11: Added glusterVolumeTopWrite verb .................................................... File vdsm/gluster/cli.py Line 892: raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)]) Line 893: Line 894: Line 895: @exportToSuperVdsm Line 896: def volumeTopOpen(volumeName, brickName=None, count=None): Add docstring describing return value structure Line 897: command = _getGlusterVolCmd() + ["top", volumeName, "open"] Line 898: if brickName: Line 899: command += ["brick", "%s" % brickName] Line 900: if count: -- To view, visit http://gerrit.ovirt.org/7844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96486363a9acb7472014a67fcd2d5185d4f3c428 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
