Xu He Jie has posted comments on this change. Change subject: Add simple text-based console in vdsClient ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm_cli/vdsClient.py Line 1614: protocol = "tls" if self.useSSL else "tcp" Line 1615: conn = "qemu+" + protocol + "://" + self.server + "/system" Line 1616: p = subprocess.Popen(["virsh", "-c", conn, "console", args[0]]) Line 1617: p.wait() Line 1618: return 0, '' Zheng Sheng, Thanks for your review! For the frist and second question. In normally, we shouldn't access libvirt directly. But for we want to have console now, this is a simple implement. When ssl=false in vdsm.conf, vdsm will configure libvirt with tcp_listen=1 and tls_listen=0. When ssl=true, vdsm will configure libvirt with tcp_listen=1 and tls_listen=1. vdsClient is vdsm's client. vdsClient isn't a virsh, so we won't provide option for user to choice connection protocol, just use vdsm's configuration. For the third question. I think you are right. In the beginning, I think vmName is more readable. But for same behavior with other command, I think uuid is better. Line 1619: Line 1620: Line 1621: if __name__ == '__main__': Line 1622: if _glusterEnabled: -- To view, visit http://gerrit.ovirt.org/8041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368dbcbc2e180161f256f3fb450c344acb6a6c8a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
